no-negated-in-lhs

! binds tighter than in, so !key in cache means (!key) in cache. It asks whether cache has a property named "true" or "false", which is almost never the question. The negation belongs around the whole test.

ESLint has deprecated this rule. Use no-unsafe-negation instead, which also covers instanceof.

Examples

Reported:

if (!key in cache) {
  cache[key] = load(key);
}

Not reported:

if (!(key in cache)) {
  cache[key] = load(key);
}