no-else-return

When the if branch ends with return, the code after the if only runs if the condition was false. An else around that code adds a level of indentation and says nothing new.

--fix removes the else and moves its content out of the block, unless a name declared in the block would clash with one outside it.

Configure

Off by default. To turn it on:

[lint.rules]
"no-else-return" = "error" # or "warn"

Every option, set to its default:

[lint.rules]
"no-else-return" = ["error", {
  allowElseIf = true,
}]

Examples

Reported:

function label(user) {
  if (user.admin) {
    return "Admin";
  } else {
    return "Member";
  }
}

Not reported:

function label(user) {
  if (user.admin) {
    return "Admin";
  }
  return "Member";
}

Options

Option	Default	What it does
allowElseIf	true	Allow else if after a branch that returns.

By default an else if is fine:

function label(user) {
  if (user.admin) {
    return "Admin";
  } else if (user.guest) {
    return "Guest";
  }
  return "Member";
}

The last else of a chain is still reported if every branch before it returns:

function label(user) {
  if (user.admin) {
    return "Admin";
  } else if (user.guest) {
    return "Guest";
  } else {
    return "Member";
  }
}

With allowElseIf: false, the else if is reported too:

function label(user) {
  if (user.admin) {
    return "Admin";
  } else if (user.guest) {
    return "Guest";
  }
  return "Member";
}