| | Remove use of DeprecatedAtOrEmptyValue in animations |
| |  |
| | kevers@ removed the usage of DeprecatedAtOrEmptyValue in the animations code base. |
| | Here is the design
doc for WTF::HashMap<>::at() refactor. |
| | Cleanup of CompositorKeyframeModel constructors |
| | kevers@ cleaned up the CompositorKeyframeModel constructors. |
| | The issues are: |
| | 3 public and 1 private constructor. All public versions end up
calling the private constructor |
| | Unnecessary if-else construct |
| | Opportunity to improve efficiency with move-value
semantics |
| | Resolution: |
| | Single constructor that takes a KeyframeModel::PropertyId
argument |
| | Add move constructor and move assignment operator to
TargetPropertyId |
| | Negative
line count CL. |
| | Refactor Native PaintWorklet |
| | xidachen@ refactor the native paintworklet code. |
| | Detailed design doc
here. |
| | The refactor reduced a middle layer, and made the entire
workflow simpler. |
| | Landed 3 CLs. (Part1,
Part2,
Part3) |
| | Magic behind move-value |
| | kevers@ learned something about std::move. |
| | Move constructor |
| | Foo::Foo(Foo&& other): other is a temporary object that may have
its contents reset as a result of the move. Note the r-value ref cannot be
const. |
| | Move assignment: |
| | Foo::operator=(Foo&& other): same thing. Other is temporary and
may be reset. |
| | Foo foo = CreateExpensiveObject(...) |
| | In this case, no std::move is required since RHS is already an r-value. |
| | Foo expensive_foo_instance = TakeOwnership(std::move(expensive_foo_instance)); |
| | std::move is required to take advantage of move-value semantics since expensive_foo_instance is an l-value. Adding std::move converts to an R-value reference. |
| | Useful instead of const & when not able to share an instance but can pass ownership. Further reading. See also pkastings C++ 201 talks. |
| |
